[FFmpeg-devel] [PATCH] RTSP-MS 10/15: ASF header parsing

[Ronald S. Bultje]

Hi,

On Wed, Feb 4, 2009 at 12:24 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Feb 04, 2009 at 11:53:02AM -0500, Ronald S. Bultje wrote:
>> On Wed, Feb 4, 2009 at 11:48 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > and then one wonders why the enum is part of the public api at all?
>>
>> Right, so the add_comments.patch (other mail) comments that it isn't,
>> similar as for LOWER_TRANSPORT_LAST.
>
> let me ask i differently
> why is the enum in a installed public header?

It's used in RTSPState, which is used in some rtp*.c files as well.

If it were a struct, I'd have defined it opaquely and declare it only
within rtsp.c, but C unfortunately does not support that concept for
enums (i.e. enum RTSPTransport in rtsp.h and then enum RTSPTransport {
.. } in rtsp.c).

Ronald