[FFmpeg-devel] [RFC] Split rtp.h

Ronald S. Bultje rsbultje
Wed Feb 4 15:13:57 CET 2009


Hi,

On Wed, Feb 4, 2009 at 9:02 AM, Luca Abeni <lucabe72 at email.it> wrote:
> As a result, the patch contains things like
> -    if ((s->read_buf_index == MAX_FRAMES_PER_PACKET) || (len && (len +
> size) > max_packet_size)) {
> -        int au_size = s->read_buf_index * 2;
> +    if ((s->num_frames == MAX_FRAMES_PER_PACKET) || (len && (len + size) >
> max_packet_size)) {
> +        int au_size = s->num_frames * 2;

I thought I commented on that previously, but google doesn't show my
reply so it is probably non-existent.
http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-January/059517.html
I'd suggest to do this in a separate commit first, add the extra field
in RTPDemuxContext before you split.

Other then that, great patch, please apply. Will you help commenting
rtp*.h also?

Ronald




More information about the ffmpeg-devel mailing list