[FFmpeg-devel] [PATCH] RTSP-MS 10/15: ASF header parsing

Luca Abeni lucabe72
Wed Feb 4 09:46:47 CET 2009


Michael Niedermayer wrote:
>>>> You want documentation of struct members, or cleanup of code?
>>> i want them documented then when i understand the code i can say if it
>>> needs a cleanup.
>> Attached are 3 patches that (in rtsp.h):
>> - add comments
>> - reindent a few comments
>> - group a few comments so they are not completely useless
>> Any other files that need comments? rtp.h seems pretty good so far,
> compared to what?
> /dev/random?
> no IMO rtp.h is very poorly documented

Sorry for stepping into this discussion... I did not notice it before
because of the "ASF" thing in the subject ;-)
Anyway, I plan to split rtp.h in multiple files (rtp.h rtpdec.h and
rtpenc.h) so that all the "muxer related" thing are isolated in one
dedicated header (I posted a patch some time ago, but then I got
sidetracked by something else... Sorry about that).

After that, I can take care of fixing, cleaning up, and documenting
all the rtpenc.h things.
So, hopefully my patch can help this cleanup & documentation effort.
I'll post an updated version of my patch (with some related
questions ;-) later.


More information about the ffmpeg-devel mailing list