[FFmpeg-devel] [PATCH] [ISSUE 793] Fix mp3 identification regressions

[Michael Niedermayer]

On Tue, Feb 03, 2009 at 07:57:23PM -0500, Alex Converse wrote:
> On Sat, Jan 31, 2009 at 5:26 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Fri, Jan 30, 2009 at 08:01:25PM -0500, Alex Converse wrote:
> >> On Fri, Jan 30, 2009 at 4:46 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Thu, Jan 29, 2009 at 12:31:52PM -0500, Alex Converse wrote:
> >> >> On Thu, Jan 29, 2009 at 12:28 PM, Alex Converse <alex.converse at gmail.com>wrote:
> >> >>
> >> >> > Right now MP3 files with ID3v2 tags bigger than 2MB no longer identify as
> >> >> > MP3. This patch makes the mp3 probe return 1 on files with id3v2 tags where
> >> >> > mp3 was not identified to make these files identiy as MP3 on the last probe
> >> >> > pass. A more elegant solution would be for the probes to be able to request
> >> >> > seeking, however it seems that that would piss all over the API. I know
> >> >> > Michael had suggested a return value to request more data in general but in
> >> >> > theory ID3v2 can grow over 256 MB and I'm nto sure we'd want to sent that
> >> >> > much information to the probe.
> >> >> >
> >> >>
> >> >> I suppose it might be helpful if I actually attach the patch.
> >> >
> >> > iam not against this patch id just like to make sure you understand that
> >> > it will not be nearly as reliably as you might think, other codecs also
> >> > make wild guesses and return 1 on random data on occasion
> >> >
> >>
> >> I see what you are saying here. The old code used to give us
> >> AVPROBE_SCORE_MAX/2+1 on all files that had id3v2 tags. Do you think
> >> return AVPROBE_SCORE_MAX/4-1 would be appropriate for any file with an
> >> id3v2 tag?
> >
> > its probably better than 1, still best would be to fix the probe API to
> > allow formats to request more data.
> >
[...]
> For the time being I'd like commit the patch attached in this message
> if no one objects.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090204/3dab8737/attachment.pgp>