[FFmpeg-devel] [PATCH] use new metadata API in asf muxer

[Aurelien Jacobs]

Ronald S. Bultje wrote:

> Hi Aurel,
> 
> On Mon, Feb 2, 2009 at 6:02 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > This patch uses new metadata API in asf muxer.
> > Note that metadata is now exported in extended_content_header instead of
> > comment_header to allow writing random metadata instead of only the few
> > one allowed by comment_header.
> 
> Most asf streams I've seen do use comment_header for the "basic" tags
> and extended_content_header for these not supported by comment_header.
> Can't you do that?

Indeed that would certainly be better. And this way, basic metadata would
still be available to basic players which only read comment_header.

Attached a new version of the patch split in 2 part. The first part simply
convert current code to new metadata API. So it still only write a few
basic tags in comment_header.
Second patch adds writing of all available metadata tags in
extended_content_header.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: md_asf_enc_1.diff
Type: text/x-patch
Size: 2601 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090203/9bb79514/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: md_asf_enc_2.diff
Type: text/x-patch
Size: 2093 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090203/9bb79514/attachment-0001.bin>