[FFmpeg-devel] [PATCH] RTSP-MS 10/15: ASF header parsing

Ronald S. Bultje rsbultje
Tue Feb 3 18:15:47 CET 2009


On Tue, Feb 3, 2009 at 8:31 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> to be honest i really think the rtp/rtsp code needs MUCH more cleanup
> and documentation done before any new additions not less and later /
> a promise to do 1 of 100 cleanups afterwards

You want documentation of struct members, or cleanup of code?

The cleanup request is unfair, Luca is working on a newly written RTSP
demuxer (from scratch) and you can't stall other people's work for
that. Likewise, you can't ask me to compete with him. I can do the
documentation of struct members, with the risk of wasting time at
something Luca will replace sooner or later anyway. Luca, what's the
current state? Do you have a patch that works?

Also, I hope you're not expecting me to have a smaller cumulative LOC
after addition of RTP/ASF or RDT support. These are
non-standard-compliant, and thus require (much) extra code. The if
(server == RM) do_special_options; else do_normal_options; spaghetti
is kid of ugly in a way, but the alternative is to come up with a
complete framework for doing all these tiny little things that each
server wants (if (server_struct->special_options)
server_struct->special_options(); else do_normal_options;). I
personally think it'd just get more complex to understand.

If you insist, I'll do this. But I need a list of what has to be done.
I understand the RTSP/RTP code quite well so you have to tell me
what's not clear to you.


More information about the ffmpeg-devel mailing list