[FFmpeg-devel] [PATCH] use new metadata API in asf demuxer

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Mon, Feb 02, 2009 at 11:59:09PM +0100, Aurelien Jacobs wrote:
> > Hi,
> > 
> > Attached patch uses new the metadata API to export all the metadata tags
> > read in asf files.
> > 
> > Aurel
> > Index: libavformat/asf.c
> > ===================================================================
> > --- libavformat/asf.c	(revision 16909)
> > +++ libavformat/asf.c	(working copy)
> > @@ -141,6 +141,25 @@
> >      }
> >  }
> >  
> > +static void get_tag(AVFormatContext *s, const char *key, int type, int len)
> > +{
> 
> > +    const char *k = key;
> 
> redundant ?

right...

> > +    char value[1024];
> 
> > +    uint64_t num;
> > +    if (type <= 1) {         // unicode or byte
> > +        get_str16_nolen(s->pb, len, value, sizeof(value));
> > +    } else if (type <= 5) {  // boolean or DWORD or QWORD or WORD
> > +        num = get_value(s->pb, type);
> 
> decl & init can be merged

Indeed.
Updated patch attached.

> [...]
> also there seem to be some problem with aspect ratios from asf
> (issue690 & 457)
> iam just mentioning as you already work with asf metadata 

I may have a look at this.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: md_asf_dec.diff
Type: text/x-patch
Size: 4222 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090203/989ecabd/attachment.bin>