[FFmpeg-devel] [PATCH] use new metadata API in as demuxer

[Michael Niedermayer]

On Mon, Feb 02, 2009 at 11:59:09PM +0100, Aurelien Jacobs wrote:
> Hi,
> 
> Attached patch uses new the metadata API to export all the metadata tags
> read in asf files.
> 
> Aurel
> Index: libavformat/asf.c
> ===================================================================
> --- libavformat/asf.c	(revision 16909)
> +++ libavformat/asf.c	(working copy)
> @@ -141,6 +141,25 @@
>      }
>  }
>  
> +static void get_tag(AVFormatContext *s, const char *key, int type, int len)
> +{

> +    const char *k = key;

redundant ?


> +    char value[1024];

> +    uint64_t num;
> +    if (type <= 1) {         // unicode or byte
> +        get_str16_nolen(s->pb, len, value, sizeof(value));
> +    } else if (type <= 5) {  // boolean or DWORD or QWORD or WORD
> +        num = get_value(s->pb, type);

decl & init can be merged

[...]
also there seem to be some problem with aspect ratios from asf
(issue690 & 457)
iam just mentioning as you already work with asf metadata 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090203/07e8e9ca/attachment.pgp>