[FFmpeg-devel] [PATCH]ffplay 1/2: fix subtitles vertical resolution

[Michael Niedermayer]

On Mon, Feb 02, 2009 at 11:25:39PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > This trivial patch fixes a bug in the ffplay.c subtitle renderer
> > > (blend_subrect) which basically halves the vertical resolution of
> > > subtitles as each same source pixel is used twice.
> > > 
> > > The effect of this patch can be easily seen in this sample:
> > > http://samples.mplayerhq.hu/sub/small.divx
> > 
> > patch looks ok
> 
> Patch applied.
> 
> (How is a user supposed to know how to view subtitles with ffplay?)

reading the source and randomly hitting keys and command line switches
yes, ffplay needs to provide more feedback of what happens and it should
be better documented

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

> ... defining _GNU_SOURCE...
For the love of all that is holy, and some that is not, don't do that.
-- Luca & Mans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090203/0ac12c24/attachment.pgp>