[FFmpeg-devel] [PATCH] RTSP-MS 10/15: ASF header parsing

[Michael Niedermayer]

On Sat, Jan 31, 2009 at 10:26:30PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Jan 31, 2009 at 7:51 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > asf_gb_pos is unused as well
> 
> I'll remove that line from this patch, I'll add it when it gets needed
> (4 patches later).
> 
> > and setting pb to NULL is of course better than not doing it.
> 
> Right, so my question was: will that sufficiently address your concern
> over the free'ed buffer leaving a "floating" (?) pb pointer in the
> AVFormatContext?
> 
> See attached patch, just because I like to attach patches.
> 
> Ronald

[...]

> +void ff_wms_parse_sdp_a_line(AVFormatContext *s, const char *p)
> +{
> +    if (av_strstart(p, "pgmpu:data:application/vnd.ms.wms-hdr.asfv1;base64,", &p)) {
> +        ByteIOContext gb;
[...]
> +        rt->asf_ctx->pb = NULL;

gb or pb ?


[...]
> Index: ffmpeg-svn/libavformat/rtsp.h
> ===================================================================
> --- ffmpeg-svn.orig/libavformat/rtsp.h	2009-01-31 11:21:13.000000000 -0500
> +++ ffmpeg-svn/libavformat/rtsp.h	2009-01-31 22:24:46.000000000 -0500
> @@ -108,6 +108,9 @@
>      int need_subscription;
>      enum AVDiscard real_setup_cache[MAX_STREAMS];
>      char last_subscription[1024];

> +
> +    /** Windows Media-specific entries */
> +    AVFormatContext *asf_ctx;

This explanation is unsatisfying, it doesnt awnser what that variable is/means


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090202/1897cda6/attachment.pgp>