[FFmpeg-devel] [PATCH] Make RM demuxer behave better with -an option

Kostya kostya.shishkov
Mon Feb 2 21:36:54 CET 2009


On Mon, Feb 02, 2009 at 07:47:22PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 02, 2009 at 01:37:12PM -0500, Ronald S. Bultje wrote:
> > On Mon, Feb 2, 2009 at 2:19 PM, Kostya <kostya.shishkov at gmail.com> wrote:
> > > The story so far:
> > >  FFmpeg now has RV30, RV40 (my fault) and AAC (not my fault) support. When
> > > trying to decode RV40+AAC RM file with -an option video decoder produces
> > > a lot of garbage and may crash. As I've investigated, that happens because
> > > with -an option specified RM demuxer begins to feed audio packets to video
> > > decoder.
> > 
> > My personal opinion is that that piece of code is dirty anyway
> > (ff_rm_parse_packet() for AAC doesn't read the complete RM packet, but
> > just one AAC frame), whereas for others (ATRAC3, cook, etc.) it reads
> > the multiple packets and stores them in ast->buf. Maybe for AAC, it
> > should do that also. That also allows to get rid of the special case
> > in ff_rm_retrieve_cache().
> 
> do you want to cleanup & simplify the rm demuxer? :)

Me too (or at least someone to do so). But I may be desperate and write a
patch myself.
 
> [...]
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB




More information about the ffmpeg-devel mailing list