[FFmpeg-devel] [Ffmpeg-devel] [PATCH] DV timecode

[Roman V. Shaposhnik]

On Sat, 2009-01-31 at 14:50 -0800, Baptiste Coudurier wrote:
> Hi Roman,
> 
> Roman V. Shaposhnik wrote:
> > On Thu, 2008-10-09 at 15:20 -0700, Baptiste Coudurier wrote:
> >> Hi guys,
> >>
> >> I'd like to resurrect this thread, I hope this won't cause flames this
> >> time, and I'll address all comments.
> > 
> > The DV related portion of this patch looks reasonable (although
> > it'll be up to Michael to have a final say). Except for this
> > small issue:
> > 
> > Index: libavformat/dvenc.c
> > ===================================================================
> > --- libavformat/dvenc.c (revision 15589)
> > +++ libavformat/dvenc.c (working copy)
> > .....
> >      for (buf = frame; buf < frame + c->sys->frame_size; buf += 150 * 80) {
> >          /* DV subcode: 2nd and 3d DIFs */
> >          for (j = 80; j < 80 * 3; j += 80) {
> > -            for (k = 6; k < 6 * 8; k += 8)
> > -                dv_write_pack(dv_timecode, c, &buf[j+k]);
> > -        
> > 
> > This basically means that repacking DV from one container to another
> > will not longer set the timecode but will set dv_[audio|video]_rectime,
> > dv_[audio|video]_recdate.
> > 
> > Is such behavior desired?
> 
> Yes, timecode is not related to rec date.
> 
> Still ok to apply ?

Since nobody voiced any concerns -- I'd say "yes".

Thanks,
Roman.