[FFmpeg-devel] [PATCH][6/8] Add VA API accelerated VC-1 decoding (take 3)

[Kostya]

On Mon, Feb 02, 2009 at 11:00:09AM +0100, Gwenole Beauchesne wrote:
> Hi,
> 
> On Sat, 31 Jan 2009, Kostya wrote:
> 
> >>>Err, BI type = s->pict_type == FF_BI_TYPE && v->bi_type
> >>>s->pict_type = FF_BI_TYPE is set only during parsing frame header
> >>
> >>Did you mean BI type = s->pict_type == FF_B_TYPE && v->bi_type ?
> >
> >Oh, indeed.
> 
> Thanks for the sample. Actually, it turned out that my assumptions for the 
> FFmpeg -> VA API PTYPE mappings were wrong. I switched I/P types for 
> max_bframes != 0 case and it already looked better. So, this lead me to 
> conclude that there is a single mapping for all cases, and that's the one 
> for VC-1 (table 35). No need to amend VA API either, I/P/B/BI codes fit 2 
> bits, in that order.
> 
> I verified the code path works for the following cases:
> - SP/MP with max_bframes == 0
> - SP/MP with max_bframes != 0
> - Advanced profile
> 
> Here is a new patch.
> 
> Thanks,
> Gwenole

Patch is fine by me and can be applied when other parts are in (VA API specific)
Oh, and our Diego can rightfully complain that if this code relies on VA API,
a dependency on it for decoder should be added to configure.