[FFmpeg-devel] [PATCH] libopenjpeg wrapper for jpeg2k decoding

[Jai Menon]

Hi,

On Mon, Feb 2, 2009 at 4:57 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Mon, Feb 02, 2009 at 04:48:17PM +0530, Jai Menon wrote:
>>
>> i also reworked most of the code to use get/release_buffer
>> revised patch attached.
>>
>> --- Changelog (revision 16912)
>> +++ Changelog (working copy)
>> @@ -146,6 +146,7 @@
>>  - hybrid WavPack support
>>  - R3D REDCODE demuxer
>>  - ALSA support for playback and record
>> +- OpenJPEG based JPEG 2000 decoder
>
> libopenjpeg JPEG 2000 decoder

>> --- libavcodec/libopenjpeg.c  (revision 0)
>> +++ libavcodec/libopenjpeg.c  (revision 0)
>> @@ -0,0 +1,184 @@
>> +
>> +AVCodec libopenjpeg_decoder = {
>> +    "libopenjpeg",
>> +    .long_name = NULL_IF_CONFIG_SMALL("OpenJPEG based JPEG 2000 decoder"),
>
> libopenjpeg JPEG 2000

Is it just me or does that sound incorrect?
I'll change it though if you want...

>
>> --- doc/general.texi  (revision 16912)
>> +++ doc/general.texi  (working copy)
>> @@ -162,6 +162,7 @@
>>  @item .Y.U.V       @tab X @tab X @tab one raw file per component
>>  @item animated GIF @tab X @tab X @tab Only uncompressed GIFs are generated.
>>  @item JPEG         @tab X @tab X @tab Progressive JPEG is not supported.
>> + at item JPEG2000     @tab   @tab E @tab decoding supported through external library libopenjpeg
>
> JPEG 2000

changed locally.

>
>>  @item PAM          @tab X @tab X @tab PAM is a PNM extension with alpha support.
>>  @item PCX          @tab   @tab X @tab PC Paintbrush
>>  @item PGM, PPM     @tab X @tab X
>
> You need to add the explanation for the 'E' below the table.  Copy it
> from one of the other tables.

I'm sorry but didn't quite understand what explanation is required?
and where does it have to be added?

> Diego

-- 
Regards,

Jai