[FFmpeg-devel] [PATCH] Gopher client support

[nazo]

Diego Biurrun ????????:
> On Sun, Feb 01, 2009 at 10:58:57PM +0900, nazo wrote:
>> Diego Biurrun ????????:
>>> On Sun, Feb 01, 2009 at 02:41:55PM +0900, nazo wrote:
>>>> Diego Biurrun ????????:
>>>>> On Sat, Jan 31, 2009 at 10:54:46PM +0900, nazo wrote:
>>>>>> attached new patch.
>>>>>>
>>>>>> --- libavformat/gopher.c	(revision 0)
>>>>>> +++ libavformat/gopher.c	(revision 0)
>>>>>> @@ -0,0 +1,129 @@
>>>>>> + *
>>>>>> + * Copyright (c) 2009 Toshimitsu Kimura
>>>>>> + * Copyright (c) 2000, 2001 Fabrice Bellard.
>>>>> Fabrice did not write this...
>>>> yes, but this code used libavformat/http.c as startpoint.
>>>> if unnecessary, remove it
>>> Then please say this explicitly.
>> ok, added.
>> attached new patch.
>>
>> --- libavformat/gopher.c	(revision 0)
>> +++ libavformat/gopher.c	(revision 0)
>> @@ -0,0 +1,130 @@
>> +/*
>> + * Gopher protocol for ffmpeg client
> 
> Just write "Gopher protocol" or "Gopher client".
changed

>> + * Copyright (c) 2009 Toshimitsu Kimura
>> + * Copyright (c) 2000, 2001 Fabrice Bellard.
>> + * This code is written based on libavformat/http.c.
> 
> This is still misleading.  I repeat: Fabrice did not write this.  If you
> write that this file is (C) Fabrice, you imply that he wrote it.  Instead
> write something like
> 
>   Copyright (c) 2009 Toshimitsu Kimura
> 
>   based on libavformat/http.c, Copyright (c) 2000, 2001 Fabrice Bellard
changed

attached new patch

-- 
Nazo (T.K.) <lovesyao at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gopher.diff
Type: text/x-patch
Size: 5181 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090202/5bc3b018/attachment.bin>