[FFmpeg-devel] [PATCH]Basic XSUB encoder

[Diego Biurrun]

On Mon, Feb 02, 2009 at 10:24:43AM +0100, Diego Biurrun wrote:
> On Sun, Feb 01, 2009 at 11:39:46PM +0100, Bj?rn Axelsson wrote:
> > 
> > The patch passes make test but make checkheaders fails on alsa-audio.h
> > which I doubt is my fault...
> 
> No, not your fault; I'll fix it in a moment.

Done.

> > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > +++ libavcodec/xsubenc.c	2009-02-01 23:22:13.000000000 +0100
> > @@ -0,0 +1,223 @@
> > +static int xsub_init_encoder(AVCodecContext *avctx)
> > +{
> > +}
> > +
> > +static int xsub_close_encoder(AVCodecContext *avctx)
> > +{
> > +}
> 
> av_cold

Also, I think most other such function names end in _init, _close.

You are also missing documentation and changelog updates and a minor
version bump.

Diego