[FFmpeg-devel] [PATCH] RTSP-MS 13/15: transport context

[Michael Niedermayer]

On Sat, Jan 31, 2009 at 07:35:28PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Jan 31, 2009 at 7:28 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > I dont have a clear understanding or the RTP/RTSP code and so i wont
> > approve patches to it except for the parts that i do understand.
> > Your explanation above is lacking badly at many points, example being
> > "In my parse_packet() implementation for the RTP/ASF payloads, I want
> >  to use a value from the RTSP demuxer's RTSPState"
> > which value? and why? the whole just smells even without understanding
> > the whole picture it feels very hackish.
> 
> For ASF-over-RTP, I use the ASF demuxer for all ASF-related stuff. I

thats clear and needed sadly


> store the ASF demuxer context in the RTSP demuxer "private" context
> (RTSPState)->asf_ctx, so that it's shared between all streams in the
> session. That value needs to be accessible from the streams.

of course

why do they not have access to it? I mean why is RTSPState / AVFormatContext
not passed to the respective functions?

It seems that either
A. its "wrong" and the functions really should not have access and no
   way of passing the context is correct ( like if a decoder tried to
   access a demuxers context ...)
B. RTSPState / AVFormatContext should be passed directly

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090201/52f793bf/attachment.pgp>