[FFmpeg-devel] [PATCH] Implement avfilter_add_colorspaces()

Stefano Sabatini stefano.sabatini-lala
Thu Dec 31 18:38:10 CET 2009


On date Thursday 2009-12-31 17:54:20 +0100, Michael Niedermayer encoded:
> On Thu, Dec 31, 2009 at 01:48:29AM +0100, Stefano Sabatini wrote:
> > On date Thursday 2009-12-31 01:18:27 +0100, Michael Niedermayer encoded:
> > > On Wed, Dec 30, 2009 at 01:32:36AM +0100, Stefano Sabatini wrote:
> > [...]
> > > > Index: libavfilter-soc/ffmpeg/libavfilter/avfilter.h
> > > > ===================================================================
> > > > --- libavfilter-soc.orig/ffmpeg/libavfilter/avfilter.h	2009-12-30 01:24:53.000000000 +0100
> > > > +++ libavfilter-soc/ffmpeg/libavfilter/avfilter.h	2009-12-30 01:25:01.000000000 +0100
> > > > @@ -192,6 +192,12 @@
> > > >  AVFilterFormats *avfilter_make_format_list(const enum PixelFormat *pix_fmts);
> > > >  
> > > >  /**
> > > > + * Adds pix_fmt to the list of formats pointed by formats, and updates
> > > > + * formats to point to the new updated list.
> > > > + */
> > > > +void avfilter_add_colorspace(AVFilterFormats **formats, enum PixelFormat pix_fmt);
> > > 
> > > why **formats and not *formats ?
> > 
> > The list of formats is re-allocated, so its address may
> > change. Alternatively we could have:
> 
> formats->formats is reallocated, i dont see formats being

Ouch lack of sleep I guess...
-- 
FFmpeg = Frenzy and Frightening Merciless Portable Elitist Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-add-colorspace.patch
Type: text/x-diff
Size: 1374 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091231/af31a31a/attachment.patch>



More information about the ffmpeg-devel mailing list