[FFmpeg-devel] [PATCH] Make ffplay define in the encoder the?number of threads *before* to open it

Stefano Sabatini stefano.sabatini-lala
Mon Dec 28 23:45:10 CET 2009


On date Monday 2009-12-28 00:07:57 +0100, Michael Niedermayer encoded:
> On Sun, Mar 09, 2008 at 03:54:35PM +0100, Michael Dorr wrote:
> > On Sunday 09 March 2008 02:59:30 pm Stefano Sabatini wrote:
> > > On date Saturday 2008-03-08 21:03:17 +0100, Michael Niedermayer encoded:
> > > > On Sat, Mar 08, 2008 at 06:33:27PM +0100, Stefano Sabatini wrote:
> > > > [...
> > > >
> > > > > Index: ffplay.c
> > > > > -    enc->thread_count= thread_count;
> > 
> > [...]
> > 
> > > Without threads enabled enc->thread_count isn't set, so it defaults to the
> > > sane value of 1.
> > 
> > I hope this doesn't qualify as thread hijacking, but the same patch (remove 
> > setting enc->thread_count) should also be applied to ffmpeg.c (attached).
> > 
> > Regards
> > 
> > -- 
> > Michael
> 
> >  ffmpeg.c |    3 ---
> >  1 file changed, 3 deletions(-)
> > e0ef035296de4281042fdb7d73f17b33267aa132  donotset_threadcount_ffmpeg.diff
> 
> ok if tested and multitheraded decoding AND encoding still works

Applied.
-- 
FFmpeg = Fostering Faithful Meaningful Puristic EnGine



More information about the ffmpeg-devel mailing list