[FFmpeg-devel] [PATCH][VAAPI][6/6] Add H.264 bitstream decoding (take 20)

[Gwenole Beauchesne]

Hi,

Le 27 d?c. 09 ? 22:46, Michael Niedermayer a ?crit :

>> +    va_pic->picture_id = ff_vaapi_get_surface(pic);
>
> i think it should be called ff_vaapi_get_surface_id()

Would a separate patch that s/ff_vaapi_get_surface/ 
ff_vaapi_get_surface_id/ existing vaapi*.[ch] be OK?

>> +    /* Fill in VAPictureParameterBufferH264. */
>> +    pic_param = ff_vaapi_alloc_picture(vactx,  
>> sizeof(VAPictureParameterBufferH264));
>
> we have a VAPictureH264 and a VAPictureParameterBufferH264
> a function called ff_vaapi_alloc_picture() is not named  
> appropriately to
> allocate a Parameter Buffer

Would a separate patch that s/ff_vaapi_alloc_picture/ 
ff_vaapi_alloc_pic_param/ existing vaapi*.[ch] be OK?

Thanks,
Gwenole.