[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Mohamed Naufal]

2009/12/27 Michael Niedermayer <michaelni at gmx.at>

> On Sat, Dec 26, 2009 at 11:22:15PM +0530, Mohamed Naufal wrote:
> > 2009/12/26 Diego Biurrun <diego at biurrun.de>
> [...]
> > +static int yop_probe(AVProbeData *probe_packet)
> > +{
> > +    if (AV_RB16(probe_packet->buf) == AV_RB16("YO") &&
> > +        probe_packet->buf[6] && probe_packet->buf[7] &&
> > +        !(AV_RL16(probe_packet->buf + 8) & 1) &&
> !(AV_RL16(probe_packet->buf + 10) & 1))
> > +        return AVPROBE_SCORE_MAX / 2 + 1;
>
> does this pass probetest?
>
>

It does. Were you suggesting returning a higher score?

[...]


> > +AVInputFormat yop_demuxer = {
> > +    "yop",
> > +    NULL_IF_CONFIG_SMALL("Psygnosis YOP Format"),
> > +    sizeof(YopDecContext),
> > +    yop_probe,
> > +    yop_read_header,
> > +    yop_read_packet,
> > +    .extensions = "yop",
>
> missing code to free packets
>


Freeing both sound & video packets in read_close() results in a double free
when read_packet() fails and packets are freed in it. So can I move all
free_packet() calls to read_close() and use flags for selective freeing?

[...]

Naufal