[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Mohamed Naufal]

2009/12/26 Diego Biurrun <diego at biurrun.de>

[...]


>
> It seems I accidentally deleted one line too many from your patch.
> What I meant to suggest is that you place the "else if" on the same
> line as the closing brace of the preceding if.
>
>
Fixed.


> > --- libavformat/yop.c (revision 0)
> > +++ libavformat/yop.c (revision 0)
> > @@ -0,0 +1,175 @@
> > +
> > +static int yop_probe(AVProbeData *probe_packet)
> > +{
> > +    if (AV_RB16(probe_packet->buf) == AV_RB16("YO") &&
> > +        !(AV_RL16(probe_packet->buf + 8) & 1) &&
> !(AV_RL16(probe_packet->buf + 10) & 1))
> > +        return AVPROBE_SCORE_MAX / 2 + 1;
>
> You no longer check probe_packet->buf[6] and [7]?
>
>
Changed (probe_packet->buf[6]  != 0) to probe_packet->buf[6]

> +    if (yop->stream == 0) {
>
> if (!yop->stream)
>
>
Done.

[...]

> +        ret = get_buffer(pb, yop->video_packet.data + palette_size,
> actual_video_data_size);
>
> Break this long line.
>
>
Fixed.

[...]


>
> No more comments from my side, let's see if Michael has anything else to
> say.
>
>
Diego
>

:D

[...]

Naufal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yop_demux.patch
Type: text/x-patch
Size: 7644 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091226/9380289e/attachment.bin>