[FFmpeg-devel] [PATCH] Simplify libSDL configuration

Stefano Sabatini stefano.sabatini-lala
Tue Dec 22 23:31:46 CET 2009


Hi, this resulted harder than I thought.

libSDL added support to SDL_VideoInfo.current_{w,h} in r1501
2005-01-04, and bumped minor (1.2.9 -> 1.2.10) in r1754 2006-01-04, so
my first idea is to use the version numbers for checking that feature.

Since r1754 is a rather ancient version, I'm quite confident there
shouldn't be many people around affected by this change.

Also I'm not sure ffplay can compile with libSDL 1.3 (I'll check if
no-one can confirm though).

The second idea is to avoid to use the sdl-config --cflags and
sdl-config --ldflags, in my system those corresponds to:
stefano at geppetto ~/s/ffmpeg> sdl-config --libs
-L/usr/lib -lSDL
stefano at geppetto ~/s/ffmpeg> sdl-config --cflags
-I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT

I'm not sure if -D_GNU_SOURCE=1 -D_REENTRANT may break something.

sdl is set as a configurable option, and is enabled by default, if
the configuration fails then the user is allowed to do --disable-sdl.

Regards.
-- 
FFmpeg = Fiendish & Furious Meaningful Proud Erroneous Geek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clean-libsdl-configure.patch
Type: text/x-diff
Size: 4253 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091222/4e2941d1/attachment.patch>



More information about the ffmpeg-devel mailing list