[FFmpeg-devel] [PATCH] Add pad filter

Artur Bodera abodera
Tue Dec 22 22:19:19 CET 2009


On Mon, Dec 21, 2009 at 11:30 PM, Stefano Sabatini <
stefano.sabatini-lala at poste.it> wrote:

>
> Attached an updated version, let me know if you find other problems
> with it.
>

Looks clear for now. Tested with previous scenarios and it's working
correctly. I appreciate various filter combinations I can use along with
vf_pad. Now my multi-video-concat script can normalize their sizes and
stretch+pad when needed.

Thanks!

ps: because of the fact, that core ffmpeg functionality is broken (-pad*
param) there is one more reason to speed up reviewing and commit pad filter
to the main repo. Otherwise another group of people will leave ffmpeg behind
and switch to alternative (read: working) video encoders.

Additionally, to keep it backward-compatible, I suggest putting a simple
logic to the existing -pad* params to implicitly add vf_pad to the end of
filter chain. A note on this should be dropped in the faq/man - anyways, it
will comply to the last-year's logic that padding is applied after resize
(i.e. at the end of filter chain). Another note should state, that if one
wanted to change this behavior, he/she should start using pad filter instead
of -pad* params (educational value :-) )


-- 

     __
    /.)\   +48 695 600 936
    \(./   abodera at gmail.com



More information about the ffmpeg-devel mailing list