[FFmpeg-devel] [PATCH] Xxan decoder

Michael Niedermayer michaelni
Sat Dec 19 19:16:27 CET 2009


On Sat, Dec 19, 2009 at 08:01:18PM +0200, Kostya wrote:
> On Sat, Dec 19, 2009 at 06:37:51PM +0100, Michael Niedermayer wrote:
> > On Sat, Dec 19, 2009 at 07:22:38PM +0200, Kostya wrote:
> > > On Sat, Dec 19, 2009 at 02:45:44PM +0100, Diego Biurrun wrote:
> > > > On Sat, Dec 19, 2009 at 01:38:02PM +0200, Kostya wrote:
> > > > > Now as clean patch (without docs or field clarification).
> > > > 
> > > > Neat, I need to test this soonish.  Does it decode all samples?
> > > 
> > > Seems so.
> > >  
> > > > > I also recommend leaving it for some student to finish.
> > > > 
> > > > Will that ever happen? :)
> > > 
> > > Who knows, it's mostly style & small bugfixing anyway.
> > > 
> > > [patch nits]
> > > Now even closer to ideal ;)
> > 
> > please also fix the issues ive raised or explain why not
> > I dont mind at all if you disagree on some but please dont just fix a
> > subset without comment on the remaining.
> 
> I think I've fixed a deal of your issues too except for giving better
> names to bufferN variables (you know, developers and names ...)

ok, forget the names, ill try to think of some better names once its in svn
well unless i forget ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091219/51b3a00b/attachment.pgp>



More information about the ffmpeg-devel mailing list