[FFmpeg-devel] [PATCH][RFC] add a list of generic tag names

[Michael Niedermayer]

On Tue, Dec 15, 2009 at 09:55:36PM +0100, Anton Khirnov wrote:
> On Tue, Dec 15, 2009 at 03:39:02PM +0100, Michael Niedermayer wrote:
> > 
> > Well, you probably are correct, it just felt more correct when i read
> > the change from ffmbc.
> > If you send a patch that reverts it ill approve it.
> > 
> OTOH artist is much more widely used in both containers and other apps.
> I'd say we add a compatibility hack to av_metadata_conv() that will set
> author from artist and vice versa, which will be removed on next major
> bump.

fine with me as well


> > 
> > Well, iam not sure if this is a reasonable description
> > 
> I failed to find a non-redundant description of genre (and i'm pretty
> sure it doesn't need one). i'm open to suggestion though, if anyone has
> a good idea.
> > 
> > amigous, X-sort-eng or X-eng-sort ?
> > 
> better now?
> 
> Anton Khirnov

>  asf.c             |    7 ++-----
>  avformat.h        |   46 ++++++++++++++++++++++++++++++++++++++++------
>  id3v1.c           |    2 +-
>  id3v2.c           |   15 ++++++++++-----
>  matroska.c        |    3 +--
>  matroskadec.c     |    2 +-
>  metadata.c        |   13 +++++++++++++
>  metadata_compat.c |    3 +++
>  mov.c             |    2 +-
>  movenc.c          |    8 ++++----
>  mp3.c             |    2 +-
>  oggparsevorbis.c  |    2 --
>  12 files changed, 77 insertions(+), 28 deletions(-)
> 6198d340d3fc2199b4d3934f3abe511f9db691e2  0001-Add-a-list-of-generic-tags.patch
> From 720860826f07c0fe4b855d0a4b43f509d5627e3b Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Fri, 25 Sep 2009 22:50:15 +0200
> Subject: [PATCH] Add a list of generic tags and change demuxers to follow it.
> 
> ---
>  libavformat/asf.c             |    7 +----
>  libavformat/avformat.h        |   46 +++++++++++++++++++++++++++++++++++-----
>  libavformat/id3v1.c           |    2 +-
>  libavformat/id3v2.c           |   15 +++++++++----
>  libavformat/matroska.c        |    3 +-
>  libavformat/matroskadec.c     |    2 +-
>  libavformat/metadata.c        |   13 +++++++++++
>  libavformat/metadata_compat.c |    3 ++
>  libavformat/mov.c             |    2 +-
>  libavformat/movenc.c          |    8 +++---
>  libavformat/mp3.c             |    2 +-
>  libavformat/oggparsevorbis.c  |    2 -
>  12 files changed, 77 insertions(+), 28 deletions(-)
> 
> diff --git a/libavformat/asf.c b/libavformat/asf.c
> index cf01e07..60bdef1 100644
> --- a/libavformat/asf.c
> +++ b/libavformat/asf.c
> @@ -129,12 +129,9 @@ const ff_asf_guid ff_asf_digital_signature = {
>  };
>  
>  const AVMetadataConv ff_asf_metadata_conv[] = {
> -    { "AlbumArtist", "artist"    },
>      { "AlbumTitle" , "album"     },
> -    { "Author"     , "author"    },
> -    { "Genre"      , "genre"     },
> -    { "Copyright"  , "copyright" },
> +    { "Author"     , "artist"    },
>      { "TrackNumber", "track"     },
> -    { "Year"       , "year"      },
> +//  { "Year"       , "date"      }, TODO: conversion year<->date
>      { 0 }
>  };
[...]
> diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c
> index 6222962..348cbca 100644
> --- a/libavformat/oggparsevorbis.c
> +++ b/libavformat/oggparsevorbis.c
> @@ -36,8 +36,6 @@
>   * http://xiph.org/vorbis/doc/v-comment.html
>   */
>  const AVMetadataConv ff_vorbiscomment_metadata_conv[] = {
> -    { "ARTIST"     , "author" },
> -    { "DATE"       , "year"   },
>      { "TRACKNUMBER", "track"  },
>      { 0 }
>  };
> -- 
> 1.6.5.3
> 

ok if tested and above doesnt cause upper/lower case changes on muxing
that violate some spec


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091216/cfb7c4b5/attachment.pgp>