[FFmpeg-devel] [PATCH/RFC] Detecting EOF in RTMP

Martin Storsjö martin
Thu Dec 10 16:48:03 CET 2009


On Thu, 10 Dec 2009, Kostya wrote:

> Looks OK, if someone can test it does not have regressions against
> unpatched code on RTMP streams from
> http://wiki.multimedia.cx/index.php?title=RTMP
> then he can apply it, otherwise I'll do that tomorrow.

Ok, great!

Would it btw be good to add a

if (rt->state == STATE_STOPPED)
    return AVERROR_EOF;

to the beginning of get_packet? Otherwise an extra call to get_packet 
after receiving the EOF could trigger reading another rtmp packet, which 
could block (almost) indefinitely?

// Martin



More information about the ffmpeg-devel mailing list