[FFmpeg-devel] [PATCH] x4->params.analyse.b_weighted_bipred gets wrong bool value in libx264.c

[Loren Merritt]

On Sun, 6 Dec 2009, Erik Slagter wrote:

> I am not sure about the _exact_ semantics of this field, but according
> to the source of x264 and compare runs it seems that value of this field
> must be either 0 or 1, and not 0 or 32 what ffmpeg uses. A shallow
> glance at the code inside libx264 suggests it does make a difference to
> use 32 or 1 for true, so I'd rather have it correct.

If a boolean field in x264.h acts differently depending on which true 
value you give it, that's a bug in libx264. However, that does not appear 
to be the case here. I just tried it, and weightb=32 does the same as 
weightb=1.

--Loren Merritt