[FFmpeg-devel] Is av_log_level supposed to be exported?

Michael Niedermayer michaelni
Thu Dec 3 12:14:51 CET 2009


On Thu, Dec 03, 2009 at 09:52:44AM +0100, Diego Biurrun wrote:
> On Thu, Dec 03, 2009 at 04:47:28AM +0100, Michael Niedermayer wrote:
> > On Wed, Dec 02, 2009 at 10:42:36PM -0200, Ramiro Polla wrote:
> > > 
> > > av_log_level from libavutil/log.c is only used in that file. It is not
> > > declared in libavutil/log.h. It's meant to be used with the
> > > av_log_get_level() and av_log_set_level() functions.
> > > 
> > > Should it be made static in log.c, or declared in libavutil/log.h so
> > > users can access it directly?
> > 
> > should be made static in the next maj ver bump
> 
> Why care about API abuse?  I'd just make it static right away...

IIRC it was once the only way to set the field, so some appliations
might still use it.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091203/1de95029/attachment.pgp>



More information about the ffmpeg-devel mailing list