[FFmpeg-devel] [BUG, PATCH] Revert broken use of ff_put_string() in vorbis_enc.c

Michael Niedermayer michaelni
Wed Dec 2 17:08:59 CET 2009


On Sat, Nov 28, 2009 at 06:52:19PM +0100, Philipp Matthias Hahn wrote:
> Revert commit 20095: Don't use ff_put_string in vorbis encoder.
> 
> ff_put_string() is declared in bistream.c, which uses put_bits() without
> BITSTREAM_WRITER_LE being defined.
> vorbis_enc.c on the other hand #defines BITSTREAM_WRITER_LE and thus must not
> use this function.
> 
> Broken files contain the string "vorsib" instead of "vorbis".

If this has not been fixed differently yet, patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091202/20a1745e/attachment.pgp>



More information about the ffmpeg-devel mailing list