[FFmpeg-devel] [PATCH] wmapro decoder

[Sascha Sommer]

Hi,

On Dienstag, 25. August 2009, Diego Biurrun wrote:
> On Fri, Aug 21, 2009 at 07:33:45PM +0200, Sascha Sommer wrote:
> > I attached an updated patch. As you might have already noticed, I do not
> > have much time to work on this project so please keep the focus on the
> > important things. I do not mind if Diego or someone else fixes the
> > alignment, coding style, typo and wording problems directly in the SVN
> > sources or if these things are pointed out in a single review but it is
> > very frustrating to resubmit this patch again and again and to synchonize
> > the main and soc svn for things that in the end do not give any real
> > benefit. This is an unacceptable waste of my time. Thanks.
>
> I do not agree that there is no real benefit, nor that this wastes your
> time in measurable quantities since you will have to go a few more
> rounds with Michael anyway.

Maybe that was a bit harsh. But even if it does not waste my time in 
measurable quantities, it surely kills my motivation to work on the decoder. 
Don't understand me wrong. I think that it is a good idea to have a common 
coding style for a project with the size of ffmpeg. However I - for the code 
that I am submitting - would prefer it if cosmetic issues are brought up for 
larger patches only at the end of the review phase once the other parts of 
the code are stable. If I spend my time fixing the indentation of code that 
will have to be removed in a different revision, the time is definitly 
wasted.

>
> But alas, there is nothing I would rather do than help you get this into
> the tree.  So I just sat down and improved/synchronized both the FFmpeg
> and the SoC tree.
>

Thanks.

Regards

Sascha