[FFmpeg-devel] [PATCH] Bluray Subtitle Support, v7 (Updated patch to v11)

[Michael Niedermayer]

On Mon, Aug 24, 2009 at 08:08:18PM +1000, Stephen Backway wrote:
> On Sun, 2009-08-23 at 22:56 +0200, Michael Niedermayer wrote:
> > On Tue, Aug 11, 2009 at 08:43:39PM +1000, stev391 at exemail.com.au wrote:
> > > On Mon, 2009-08-10 at 14:08 +0200, Reimar D?ffinger wrote:
> > > > On Mon, Aug 10, 2009 at 09:32:40PM +1000, stev391 at exemail.com.au wrote:
> [...]
> > > +#define cm  (ff_cropTbl + MAX_NEG_CROP)
> > 
> > is gcc able to simplify that? or is there a silly const + const addition
> > in the inner loops? (i know ive seen such things that gcc couldnt optimize
> > away long ago though dont remember if it was such a construct)
> 
> This is a case of monkey see, monkey do.
> 
> This is out of my level of experience and is how it is in dvbsubdec.c
> 
> Would you like me to change it to:
> uint8_t *cm = ff_cropTbl + MAX_NEG_CROP;
> like in vp3dsp.c, svq3.c, rv40dsp.c, rv40.c etc
> 
> Or
> 
> const uint8_t *cm = ff_cropTbl + MAX_NEG_CROP;
> like in vc1dsp.c, simple_idct.c etc

i prefer const uint8_t

i will review the patch soon

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090824/5173b4e6/attachment.pgp>