[FFmpeg-devel] [PATCH] Parsing ALS object type in MPEG-4

[Michael Niedermayer]

On Fri, Aug 21, 2009 at 02:09:50AM +0200, Thilo Borgmann wrote:
> 
> >>  
> >> +    // read number of channels
> >> +    c->chan_config = 0;
> >> +    c->channels = get_bits(gb, 16) + 1;
> > 
> > align
> > 
> >> @@ -71,8 +99,19 @@
> >>  
> >> +        if (show_bits_long(&gb, 24) != 0x414C53) {
> >> +            skip_bits_long(&gb, 24);
> >> +        }
> > 
> > useless {}
> > 
> 
> Both done in revision 4.
> 
> Thanks!
> 
> -Thilo

>  libavcodec/mpeg4audio.c |   41 ++++++++++++++++++++++++++++++++++++++++-
>  libavcodec/mpeg4audio.h |    1 +
>  libavformat/mov.c       |    4 ++++
>  3 files changed, 45 insertions(+), 1 deletion(-)
> 63337c45839ec7f1e2021ca507a7f456c057e8c1  als_readconfig.rev4.patch
> Index: libavcodec/mpeg4audio.c
> ===================================================================
> --- libavcodec/mpeg4audio.c	(revision 19673)
> +++ libavcodec/mpeg4audio.c	(working copy)
> @@ -24,6 +24,34 @@
>  #include "put_bits.h"
>  #include "mpeg4audio.h"
>  
> +/**
> + * Parse MPEG-4 audio configuration for ALS object type.
> + * @param[in] gb       bit reader context
> + * @param[in] c        MPEG4AudioConfig structure to fill

> + * @return on error -1 is returned, on success 0 is returned

errors should be <0 in ffmpeg where possible, not a specific value

besides this, i leave this patch to others who know the code better
than i do, to review (baptiste/alex maybe?)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090823/6755d6d3/attachment.pgp>