[FFmpeg-devel] [PATCH] ALS decoder

[Thilo Borgmann]

> I'm not sure, but it could be he intended for you to explain what BGMC
> is (or give the full name in the comment)
> ...
> ditto
Ok.


>>>> +                k_max = FFMIN(20, opt_order);
>>>> +                for (k = 2; k < k_max; k++) {
>>>> ...
>>>> +                }
>>>> ...
>>>> +                k_max = FFMIN(127, opt_order);
>>>> +                for (k = 20; k < k_max; k++) {
>>> k=20 is redundant
>>>
>>>
>>>> +                // read coefficients 127 to opt_order
>>>> +                for (k = 127; k < opt_order; k++) {
>>> so is k=127
>> No, this is correct.
>>  for(; k < 20;)
>>  for(k = 20;;)
> 
> Correct, yes. Also redundant.
> If ..
Understood and done.


>>>> +            memcpy(ctx->prev_raw_samples, raw_samples - sconf->max_order,
>>>> +                   sizeof(int64_t) * sconf->max_order);
>>> instead of duplicating the type (int64_t) the type of the array should be used
>> Sorry I don't understand this. Please elaborate.
> 
> Perhaps
> sizeof(typeof(array)) * sconf->max_order);
Done.

Thanks for elaborating!

-Thilo