[FFmpeg-devel] [PATCH] Check malloc values in swscale.

[Ramiro Polla]

On Sun, Aug 16, 2009 at 12:02 AM, Reimar
D?ffinger<Reimar.Doeffinger at gmx.de> wrote:
> On Sat, Aug 15, 2009 at 09:15:30PM -0300, Ramiro Polla wrote:
>> > ?Anyway, as Reimar already suggested you might end up rewriting
>> > the routine. Just wanted to point it out, if it slipped through.
>>
>> Right. I wanted to do things one step at a time, but then I started
>> getting a review on the code that was already there, so I'll just send
>> a patchset when I'm done with everything.
>
> From my point of view feel free to just start "somewhere", it's just
> that the current code is so suboptimal that there simply "have" to be
> more changes.

3 Patches attached. The cosmetics patch does:
- Indent;
- Remove {} for one-lined fors;
- Split "for(foo) bar;" in two lines.

> Though currently I think it would make most sense to start with using
> the sws_getConstVec function where possible, it should cut down future
> diffs most.

Where can it be used that much?

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Introduce-and-use-sws_allocVec.patch
Type: text/x-diff
Size: 6167 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090816/51defba7/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Check-for-return-value-of-sws_allocVec.patch
Type: text/x-diff
Size: 2870 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090816/51defba7/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Cosmetics.patch
Type: text/x-diff
Size: 4062 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090816/51defba7/attachment-0002.patch>