[FFmpeg-devel] [PATCH] Decoding of raw UTF-8 text from Ogg streams

[ogg.k.ogg.k at googlemail.com]

>> +    if (!copy)
>> +      return;
>
> indention depth should be x*4

Fixed.

>> +#define CHK(val, mx) if ((val) < 0 || (val) >= (mx)) goto end;
>
> if the values are unsigned, >= is enough

Left as is, because:
A while ago, I realized that sscanf using %u would actually accept
negative numbers (eg, lexical minus signs in the input), and I'd end
up with large unsigned numbers. These would be accepted if I was
to do that, so I think it's best to keep to %d and test with 0. If you
confirm you prefer it to change, then just say so and I'll send an
updated patch.

> that should be a seperate patch

Done.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-add-simple-ASS-SSA-decoder.patch
Type: application/octet-stream
Size: 6957 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090816/13ad7a1e/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-avcodec_free_subtitle.patch
Type: application/octet-stream
Size: 2576 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090816/13ad7a1e/attachment-0001.obj>