[FFmpeg-devel] AMR-NB decoder

[Robert Swain]

On Thu, 13 Aug 2009 18:25:37 +0200, Michael Niedermayer
<michaelni at gmx.at> wrote:
> On Thu, Aug 13, 2009 at 09:33:49AM +0100, Colin McQuillan wrote:
> > 2009/8/13 Michael Niedermayer <michaelni at gmx.at>:
> > > On Wed, Aug 12, 2009 at 11:40:59PM +0100, Robert Swain wrote:

[...]

> > >> The only thing I don't like is the ff_scale_to() function name. I
> > >> wouldn't know what it did without reading the description. I
> > >> know a distaste for the use of 'energy' for a generic function
> > >> has been expressed but I'd understand something like
> > >> ff_acelp_scale_energy(). Does anyone have any better
> > >> suggestions? Reynaldo? Michael? Colin?
> > >
> > > if i remember what the function did ...
> > >
> > > scale_vector_to_given_sum_of_squares()
> > >
> > > its a little long though ...
> > 
> > Changed
> 
> iam not maintainer of qcelp but i think its ok given it was tested
> and works

Reynaldo, can you check/commit the agc-4 patch that was attached by
Colin earlier in this thread please? :)

Regards,
Rob