[FFmpeg-devel] [PATCH]Fix bug caused by difference in stride and picture width in libschroedingerenc and libschroedingerdec

[Anuradha Suraparaju]

Hi,

On Mon, 2009-08-10 at 14:42 +0200, Diego Biurrun wrote:
> On Mon, Aug 10, 2009 at 12:34:42PM +1000, Anuradha Suraparaju wrote:
> > 
> > The patch if for svn revision 19610.
> > 
> > --- libavcodec/libschroedinger.c	(revision 19610)
> > +++ libavcodec/libschroedinger.c	(working copy)
> > @@ -78,3 +78,57 @@
> > +
> > +static void FreeSchroFrame(SchroFrame *frame, void *priv)
> > +{
> > +    AVPicture *p_pic = priv;
> > +
> > +    if (!p_pic) {
> > +        return;
> > +    }
> 
> useless {}
> 

Fixed.

> > +SchroFrame *ff_create_schro_frame (AVCodecContext *avccontext,
> > +                                   SchroFrameFormat schro_frame_fmt)
> 
> Please use standard K&R style, i.e. no space after function names.  You
> are wildly inconsistent.

Fixed.

> 
> > +    for (i=0; i<3; ++i) {
> 
> Spaces around operators would help readability here.
> 

Fixed.

> > +        if (i != 0) {
> 
> if (i) {
> 

Fixed.

> > --- libavcodec/libschroedinger.h	(revision 19610)
> > +++ libavcodec/libschroedinger.h	(working copy)
> > @@ -57,5 +57,12 @@
> >  
> > +SchroFrame *ff_create_schro_frame (AVCodecContext *avccontext,
> > +                                   SchroFrameFormat schro_frame_fmt);
> 
> see above
> 
> more instances below
> 

Fixed.

I've attached a new patch against revision 19636 to this email.

Regards,
Anuradha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpegsvn_trunk_revision_19636_libschroedinger_encdec.diff
Type: text/x-patch
Size: 4749 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090814/06f14f3c/attachment.bin>