[FFmpeg-devel] [PATCH][RFC] Lagarith Decoder.

[Måns Rullgård]

Nathan Caldwell <saintdev at gmail.com> writes:

> 2009/8/6 M?ns Rullg?rd <mans at mansr.com>:
>> Alexander Strange <astrange at ithinksw.com> writes:
>>
>>> On Aug 6, 2009, at 5:06 PM, Nathan Caldwell wrote:
>>>
>>>> Here's my first attempt at a Lagarith decoder. At the moment it only
>>>> handles YV12 content, I do plan on adding in the other modes (RGB24,
>>>> YUY2, and RGBA). I just wanted some input on things that need changed
>>>> before I get too far along.
>>>>
>>>> +static inline uint32_t clp2(uint32_t x)
>>>
>>> This name is kind of obscure.
>>
>> Furthermore, this is generic enough that it could be useful somewhere
>> else some time. ?It should go in some header file with other similar
>> stuff. ?It can also be easily optimised on CPUs with bit-counting
>> instructions (e.g. CLZ).
>
> ciel_pow2?
> I was surprised there wasn't something like this already. The same
> goes for the planar->packed memcpy and packed memset. I was surprised
> there wasn't anything like that already. Both are currently unused
> (and horribly inefficient), but are very useful for planar->packed
> RGB.

Plane (de)interleaving can also be easily simdified.

-- 
M?ns Rullg?rd
mans at mansr.com