[FFmpeg-devel] [PATCH] RTP/QDM2 parser

[Benjamin Larsson]

Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Aug 7, 2009 at 10:46 AM, Reimar
> D?ffinger<Reimar.Doeffinger at gmx.de> wrote:
>> On Fri, Aug 07, 2009 at 10:39:36AM -0400, Alex Converse wrote:
>>> On Tue, Aug 4, 2009 at 5:15 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>> ->-- ffmpeg-svn.orig/libavcodec/qdm2.c        2009-08-03 18:36:40.000000000 -0400
>>>> +++ ffmpeg-svn/libavcodec/qdm2.c     2009-08-03 18:47:49.000000000 -0400
>>>> @@ -1277,13 +1277,13 @@
>>>>     init_get_bits(&gb, header.data, header.size*8);
>>>>
>>>>     if (header.type == 2 || header.type == 4 || header.type == 5) {
>>>> -        int csum = 257 * get_bits(&gb, 8) + 2 * get_bits(&gb, 8);
>>>> +        int csum = 257 * get_bits(&gb, 8) + 2 * get_bits(&gb, 8), cs2;
>>> I hate to be all nitpicky, but that is a really awkward declaration
>>> and touches code that is otherwise unmodified.
>>>
>>>> -        csum = qdm2_packet_checksum(q->compressed_data, q->checksum_size, csum);
>>>> +        cs2 = qdm2_packet_checksum(q->compressed_data, q->checksum_size, csum);
>> The whole chunk only changes debugging output, and as such is unrelated
>> and should be committed separately if at all IMHO
> 
> Of course it'd be done separately. It's obviously not needed for
> running, so do you want me to commit it at all, Benjamin? Otherwise
> I'll drop that part.
> 
> Ronald

If not needed then drop it.

/Benjamin