[FFmpeg-devel] LPCM for mpeg-ts

[Diego Biurrun]

On Mon, Aug 03, 2009 at 10:40:12AM +0300, Christian P. Schmidt wrote:
> Diego Biurrun wrote:
> 
> > Here and in other places you could easily break overly long lines.
> 
> Please define overly long, in a number. I think 120-130 is ok since we
> left the 1990s.

79/80

And don't kid me with 1990s nonsense.  You may have noticed that newspaper
columns did not get wider since then.  It's because our brains have not
increased in processing to match growing display resolutions.

> >> +#ifdef WORDS_BIGENDIAN
> > 
> > This is non-existing and should have caused a warning, which you must
> > have ignored.
> 
> You could just have said "we changed that recently, update your
> checkout". It compiled without warnings for me. Fixed.

-Wundef only complains for #if, my bad.

> > Your patch is missing documentation, changelog and Makefile updates.
> 
> --- ffmpeg.old/trunk/libavcodec/Makefile	2009-07-14 15:53:07.430807476 +0300
> +++ ffmpeg/trunk/libavcodec/Makefile	2009-07-30 11:40:44.434824715 +0300
> @@ -278,6 +278,7 @@
>  # (AD)PCM decoders/encoders
>  OBJS-$(CONFIG_PCM_ALAW_DECODER)           += pcm.o
>  OBJS-$(CONFIG_PCM_ALAW_ENCODER)           += pcm.o
> +OBJS-$(CONFIG_PCM_BLURAY_DECODER)         += pcm-mpeg.o
>  OBJS-$(CONFIG_PCM_DVD_DECODER)            += pcm.o
>  OBJS-$(CONFIG_PCM_DVD_ENCODER)            += pcm.o
>  OBJS-$(CONFIG_PCM_F32BE_DECODER)          += pcm.o
> 
> Which other Makefile needs updates?

None, I must have accidentally snipped the Makefile hunk from your
patch.

> For the changelog: You mean a line in the actual Changelog file? Done.

Yes.

> For the documentation: more inline for doxygen, or is external required?

doc/general.texi

> I hope the attached path gets us closer to resolution.

It does.

Diego