[FFmpeg-devel] LPCM for mpeg-ts, the third

[Diego Biurrun]

On Sun, Aug 02, 2009 at 05:50:17PM +0300, Christian P. Schmidt wrote:
> 
> Attached is another try. I incorporated most of the suggestions.
> 
> --- ffmpeg.old/trunk/libavcodec/pcm-mpeg.c	1970-01-01 03:00:00.000000000 +0300
> +++ ffmpeg/trunk/libavcodec/pcm-mpeg.c	2009-08-02 17:19:35.885878508 +0300
> @@ -0,0 +1,199 @@
> +/*
> + * PCM codecs

This is not an accurate description.

> +/**
> + * @file libavcodec/pcm-mpeg.c
> + * PCM codecs for encodings found in mpeg streams (dvd/bluray)

MPEG, DVD, Blu-ray, same below

> +static int pcm_bluray_parse_header (AVCodecContext *avctx, const uint8_t * header)

No spaces between function name and (, inconsistent * placement.

Here and in other places you could easily break overly long lines.

> +    if (0 == avctx->sample_rate) {

if (!avctx->sample_rate) {

same in other places

> +    if (pcm_bluray_parse_header (avctx, src))
> +      return -1;

indentation

> +#ifdef WORDS_BIGENDIAN

This is non-existing and should have caused a warning, which you must
have ignored.

> +#ifdef CONFIG_PCM_BLURAY_DECODER

This is wrong (#ifdef vs. #if) and unnecessary.  The file is only
compiled if the condition is true.


Your patch is missing documentation, changelog and Makefile updates.

Diego