[FFmpeg-devel] [PATCH] yuv2rgb: Trailing pixels are not converted if destination width is not multiple of 4

Michael Niedermayer michaelni
Thu Apr 30 22:58:01 CEST 2009


On Thu, Apr 30, 2009 at 09:45:31PM +0200, C?dric Schieli wrote:
> 2009/4/30 Michael Niedermayer <michaelni at gmx.at>:
> > On Mon, Apr 27, 2009 at 04:08:13PM +0200, C?dric Schieli wrote:
[...]
> > besides i dont see how it could even work, it still has to be a multiple
> > of 2.
> 
> yes, but ffmpeg do not accept an odd destination width anyway.

thats a very lame excuse, not all files are generated by ffmpeg and the
check might be removed


> I'm ok it would be better to find a full fix
> 
> >
> > also was this bug always existing or is it new since the yuv2rgb rewrite?
> 
> I did not test, but a quick look at the old yuv2rgb.c makes me think
> it was already there

until its confirmed that the old code was buggy too i think we should
refrain from adding bloat, maybe it used a simpler fix

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090430/0857ab9d/attachment.pgp>



More information about the ffmpeg-devel mailing list