[FFmpeg-devel] [PATCH] Move MLP's dot product to DSPContext

[Måns Rullgård]

Ramiro Polla <ramiro.polla at gmail.com> writes:

> +#define MUL64(state, coeff, offset, label) \
> +    MANGLE(label)":                  \n\t" \
> +    "movslq "#offset"("state"), %%rax\n\t" \
> +    "movslq "#offset"("coeff"), %%rdx\n\t" \
> +    "imul                %%rdx, %%rax\n\t" \
> +    "add                 %%rax, %%rsi\n\t" \

There is already a MUL64 macro defined in mathops.h.  Please choose
another name.  MUL isn't even very descriptive of what the macro above
does (same for your MUL32 elsewhere in the patch).

-- 
M?ns Rullg?rd
mans at mansr.com