[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing

[Luca Abeni]

Ronald S. Bultje wrote:
[...]
>> [...]
>> +        } else {
>> +            asf->buf = av_malloc(len - off);
>> +            asf->pos = len - off;
>> +            memcpy(asf->buf, buf + off, len - off);
>> +        }
>>
>> Unless microsoft is using standard headers and flags in a very
>> non-standard way, I think this code can be written in a much
>> simpler way.
> 
> I'll try to simpify. For the original version, do you "mind" if I just
> don't care about missing buffers etc. and discard everything that is
> not exactly in sync?

I suspect this is more-or-less already done by the generic RTP code...
So, no problem from me.
(yes, this will have to be fixed one day, but it is a different issue)

> I understand that eventually the idea is that
> out-of-order packets and missing packets are all handled, but is it OK
> if we don't in this first version?

Ok. Handling out-of-order and missing packets is a more generic issue
that should be addressed (if possible) in the generic RTP code... After
all, I think there is a SoC project for working on this?


> Also, generally speaking, how do I "discard" / "reset" a dyn_buf?

I do not know... I would close, free the buffer, and open the dyn_buf
again. But maybe there is a simpler solution?


				Luca