[FFmpeg-devel] [PATCH] [RFC] Second try at pixdesc.h:write_line()

[Stefano Sabatini]

On date Monday 2009-04-20 00:00:53 +0200, Michael Niedermayer encoded:
> On Sun, Apr 19, 2009 at 11:08:42PM +0200, Stefano Sabatini wrote:
> > On date Sunday 2009-04-19 20:30:01 +0200, Michael Niedermayer encoded:
> > > On Sun, Apr 19, 2009 at 06:43:15PM +0200, Stefano Sabatini wrote:
> > [...]
> > > > Well but I was looking for a more general solution, for which this one
> > > > couldn't work.
> > > 
> > > but why? which pixel format can not be handled?
> > 
> > I didn't know that, I supposed that there could be in this wild wild
> > world, now I'm happy that there are not. 
> > > > 
> > > > BTW, should be change accordingly read_line()?
> > > 
> > > i cant parse this sentance
> > 
> > I meant:
> > "BTW, should we change read_line() accordingly?
> > 
> > What I meant was to remove dependancy on get_bits.h, like in the
> > attached patch.
> 
> benchmark?

stefano at geppetto ~/s/l/ffmpeg> 
ffplay ~/samples/aikido.mp4 -vfilters "format=monow, pixdesc_test"
FFplay version SVN-r18497, Copyright (c) 2003-2009 Fabrice Bellard, et al.
  configuration: --enable-debug=3 --disable-optimizations --disable-mmx --enable-avfilter --disable-stripping --enable-gpl --enable-avfilter_lavf
  libavutil     50. 3. 0 / 50. 3. 0
  libavcodec    52.25. 0 / 52.25. 0
  libavformat   52.32. 0 / 52.32. 0
  libavdevice   52. 2. 0 / 52. 2. 0
  libavfilter    0. 5. 0 /  0. 5. 0
  libswscale     0. 7. 1 /  0. 7. 1
  built on Apr 17 2009 09:05:04, gcc: 4.3.2
[format @ 0xa56cce0]auto-inserting filter 'scale'
[ffplay_output @ 0xa54c150]auto-inserting filter 'scale'
[swscaler @ 0xa5a86b0]No accelerated colorspace conversion found.
149280 dezicycles in dont_use_get_bit, 1 runs, 0 skips
142200 dezicycles in dont_use_get_bit, 2 runs, 0 skips
137640 dezicycles in dont_use_get_bit, 4 runs, 0 skips
135030 dezicycles in dont_use_get_bit, 8 runs, 0 skips
134332 dezicycles in dont_use_get_bit, 16 runs, 0 skips
133972 dezicycles in dont_use_get_bit, 32 runs, 0 skips
133509 dezicycles in dont_use_get_bit, 64 runs, 0 skips
133357 dezicycles in dont_use_get_bit, 128 runs, 0 skips
134632 dezicycles in dont_use_get_bit, 256 runs, 0 skips
134746 dezicycles in dont_use_get_bit, 512 runs, 0 skips
134266 dezicycles in dont_use_get_bit, 1024 runs, 0 skips
134293 dezicycles in dont_use_get_bit, 2048 runs, 0 skips
133997 dezicycles in dont_use_get_bit, 4096 runs, 0 skips
134014 dezicycles in dont_use_get_bit, 8192 runs, 0 skips
134046 dezicycles in dont_use_get_bit, 16383 runs, 1 skips
134082 dezicycles in dont_use_get_bit, 32766 runs, 2 skips
134498 dezicycles in dont_use_get_bit, 65533 runs, 3 skips
135501 dezicycles in dont_use_get_bit, 131065 runs, 7 skips
135101 dezicycles in dont_use_get_bit, 262128 runs, 16 skips
stefano at geppetto ~/s/l/ffmpeg> 
ffplay ~/samples/aikido.mp4 -vfilters "format=monow, pixdesc_test"
FFplay version SVN-r18497, Copyright (c) 2003-2009 Fabrice Bellard, et al.
  configuration: --enable-debug=3 --disable-optimizations --disable-mmx --enable-avfilter --disable-stripping --enable-gpl --enable-avfilter_lavf
  libavutil     50. 3. 0 / 50. 3. 0
  libavcodec    52.25. 0 / 52.25. 0
  libavformat   52.32. 0 / 52.32. 0
  libavdevice   52. 2. 0 / 52. 2. 0
  libavfilter    0. 5. 0 /  0. 5. 0
  libswscale     0. 7. 1 /  0. 7. 1
  built on Apr 17 2009 09:05:04, gcc: 4.3.2
[format @ 0x925ece0]auto-inserting filter 'scale'
[ffplay_output @ 0x923e150]auto-inserting filter 'scale'
[swscaler @ 0x92833b0]No accelerated colorspace conversion found.
512040 dezicycles in use_get_bit, 1 runs, 0 skips
494700 dezicycles in use_get_bit, 2 runs, 0 skips
559260 dezicycles in use_get_bit, 4 runs, 0 skips
527670 dezicycles in use_get_bit, 8 runs, 0 skips
542415 dezicycles in use_get_bit, 16 runs, 0 skips
541012 dezicycles in use_get_bit, 32 runs, 0 skips
545724 dezicycles in use_get_bit, 64 runs, 0 skips
548168 dezicycles in use_get_bit, 128 runs, 0 skips
547740 dezicycles in use_get_bit, 256 runs, 0 skips
547889 dezicycles in use_get_bit, 512 runs, 0 skips
522806 dezicycles in use_get_bit, 1024 runs, 0 skips
513843 dezicycles in use_get_bit, 2048 runs, 0 skips
507767 dezicycles in use_get_bit, 4096 runs, 0 skips
506833 dezicycles in use_get_bit, 8192 runs, 0 skips
501697 dezicycles in use_get_bit, 16384 runs, 0 skips
502050 dezicycles in use_get_bit, 32768 runs, 0 skips
500617 dezicycles in use_get_bit, 65535 runs, 1 skips
501156 dezicycles in use_get_bit, 131068 runs, 4 skips
499579 dezicycles in use_get_bit, 262138 runs, 6 skips
 
[...] 
> cosmetic & functional mix

Fixed.
-- 
FFmpeg = Funny Foolish Most Programmable Evil Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pixdesc-amend-read-line.patch
Type: text/x-diff
Size: 1311 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090421/b378058a/attachment.patch>