[FFmpeg-devel] [PATCH] RTSP-MS 15/15: move packet_time_start zero value assignment in asf.c

Michael Niedermayer michaelni
Thu Apr 16 20:23:03 CEST 2009


On Thu, Apr 16, 2009 at 02:12:31PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Apr 16, 2009 at 2:04 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Apr 16, 2009 at 01:55:35PM -0400, Ronald S. Bultje wrote:
> >> On Thu, Apr 16, 2009 at 1:15 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > The check you remove IS the EOF check it just returns EIO as it was
> >> > written prior to EOF being used
> >>
> >> No, that check is the one that I just changed to AVERROR_EOF in my
> >
> > that, is the second EOF check
> 
> OK, looking at this piece of code in ffplay.c:
> 
>         ret = av_read_frame(ic, pkt);
>         if (ret < 0) {
>             if (ret != AVERROR_EOF && url_ferror(ic->pb) == 0) {
>                 SDL_Delay(100); /* wait for user event */
>                 continue;
>             } else
>                 break;
>         }
> 
> OK if I change the AVERROR(EIO) to AVERROR_EOF then? (Yes, tested,
> just like all my previous patches, and playback keeps working and EOF
> is now properly recognized and playback terminated accordingly.)

good, i like this patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090416/0094544e/attachment.pgp>



More information about the ffmpeg-devel mailing list