[FFmpeg-devel] [PATCH] NEON: Add guaranteed alignment in avg_pixels16

[Måns Rullgård]

David Conrad <lessen42 at gmail.com> writes:

> Hi,
>
> 128 byte alignment is guaranteed for dst, but is currently only used
> when storing to dst.
>
>
> commit c1f778700228a23ef562fb2aebd831dd78e83205
> Author: David Conrad <davedc at Kozue.local>
> Date:   Wed Apr 15 23:22:54 2009 -0400
>
>     Add guaranteed alignment for loading dest pixels in avg_pixels16_neon
>
> diff --git a/libavcodec/arm/dsputil_neon_s.S b/libavcodec/arm/dsputil_neon_s.S
> index 5b95717..f16293d 100644
> --- a/libavcodec/arm/dsputil_neon_s.S
> +++ b/libavcodec/arm/dsputil_neon_s.S
> @@ -38,13 +38,13 @@
>          pld             [r1, r2]
>          pld             [r1, r2, lsl #1]
>  .if \avg
> -        vld1.64         {d16,d17}, [ip], r2
> +        vld1.64         {d16,d17}, [ip,:128], r2
>          vrhadd.u8       q0,  q0,  q8
> -        vld1.64         {d18,d19}, [ip], r2
> +        vld1.64         {d18,d19}, [ip,:128], r2
>          vrhadd.u8       q1,  q1,  q9
> -        vld1.64         {d20,d21}, [ip], r2
> +        vld1.64         {d20,d21}, [ip,:128], r2
>          vrhadd.u8       q2,  q2,  q10
> -        vld1.64         {d22,d23}, [ip], r2
> +        vld1.64         {d22,d23}, [ip,:128], r2
>          vrhadd.u8       q3,  q3,  q11
>  .endif
>          subs            r3,  r3,  #4
>

Good catch.  Patch OK.

-- 
M?ns Rullg?rd
mans at mansr.com