[FFmpeg-devel] GSoC Qual VQA v3 : updated patch.

[Stefano Sabatini]

On date Monday 2009-04-13 12:19:24 -0400, The Deep Explorer encoded:
> Hi,
>    Compiles, but wont do the complete thing since I am waiting on the
> vector indexing algorithm.
> Please if you could comment on the other parts of the algorithm , it
> would be extremely nice
> while I am waiting for the algorithm.
> 
> I guess I just have today , so any help is appreciated.
> 
> Things I need to do is :
> 
> i) Finish the vector index algorithm to populate the frame after
> someone tells me the vector indexing algo
> ii) Test it on vqa v3 files.
> 
> 
> Also, for vptr decoding , I am getting codes 4,6 from movies under
> blade , which are not mentioned in the document ,
> I am ignoring those right now since nothing is mentioned for them.
> 
> Look forward to some feedback.... Please help
> 
> Thanks,
> -tde
> 
> PS : patcheck reports some  NULL refs (exisitng ones not mine),and
> some other stuff which I have not introduced.

> Index: libavcodec/vqavideo.c
> ===================================================================
> --- libavcodec/vqavideo.c	(revision 18493)
> +++ libavcodec/vqavideo.c	(working copy)
> @@ -89,13 +89,16 @@
>  #define CPL0_TAG MKBETAG('C', 'P', 'L', '0')
>  #define CPLZ_TAG MKBETAG('C', 'P', 'L', 'Z')
>  #define VPTZ_TAG MKBETAG('V', 'P', 'T', 'Z')
> -

Cosmetics.

> +#define VPTR_TAG MKBETAG('V', 'P', 'T', 'R')
> +#define VPRZ_TAG MKBETAG('V', 'P', 'R', 'Z')
>  #define VQA_DEBUG 0
>  
>  #if VQA_DEBUG
>  #define vqa_debug printf
>  #else
> -static inline void vqa_debug(const char *format, ...) { }
> +static inline void vqa_debug(const char *format, ...)
> +{
> +}

Cosmetics.

>  #endif
>  
>  typedef struct VqaContext {
> @@ -108,15 +111,15 @@
>  
>      uint32_t palette[PALETTE_COUNT];
>  
> -    int width;   /* width of a frame */
> -    int height;   /* height of a frame */
> -    int vector_width;  /* width of individual vector */
> -    int vector_height;  /* height of individual vector */
> -    int vqa_version;  /* this should be either 1, 2 or 3 */
> +    int width;                  /* width of a frame */
> +    int height;                 /* height of a frame */
> +    int vector_width;           /* width of individual vector */
> +    int vector_height;          /* height of individual vector */
> +    int vqa_version;            /* this should be either 1, 2 or 3 */

Cosmetics.

And so on for most hunks.

Cosmetics changes are not forbidden but (if and *only* if they make
sense) they should be sent as different patches.

Please read again the patch submission guidelines and learn them by
heart, those rules are there to improve code quality and simplify the
review process.

If you really can't resist on doing cosmetics changes (e.g. realigning
stuff and K&R consistency) do it in separate patches/threads, but I'll
avoid them and focus only on functional changes, or you'll get swamped
in some nitpickety fight.

Regards.
-- 
FFmpeg = Foolish Fundamental Muttering Portentous Elaborated Game