[FFmpeg-devel] [PATCH] RTP/Vorbis payload implementation (GSoC qual task)

[Ronald S. Bultje]

Hi,

On Mon, Apr 13, 2009 at 9:45 AM, Colin McQuillan <m.niloc at googlemail.com> wrote:
> ffmpeg-large-fmtp-params.patch is the first patch. This allows large
> FMTP parameter values as used by Vorbis.
[..]
-    char value[4096];
+    int value_alloc = FFMIN(INT_MAX,strlen(p));
+    char *value = av_malloc(value_alloc);

How large, in practice? We generally prefer fixed values over these
virtually random numbers... I mean, by itself p is constricted to
<8092 already anyway (by virtue of that being the max SDP size), so
basically shouldn't increasing value to 8192 work?

Ronald